made it so you can turn off psql cert validation locally#88
Merged
mdellabitta merged 1 commit intomainfrom Feb 27, 2025
Merged
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 300792f in 1 minute and 24 seconds
More details
- Looked at
16lines of code in1files - Skipped
0files when reviewing. - Skipped posting
7drafted comments based on config settings.
1. src/main/resources/application.conf:42
- Draft comment:
Duplicate assignment for 'ssl'. Ensure fallback order is intentional. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
2. src/main/resources/application.conf:44
- Draft comment:
Duplicate 'sslmode' assignment. Verify that environment variable SSL_MODE is provided when needed. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
3. src/main/resources/application.conf:46
- Draft comment:
Duplicate 'sslfactory' assignment. Ensure SSL_FACTORY env var, if set, supplies a valid implementation. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
4. src/main/resources/application.conf:43
- Draft comment:
Ensure the SSL override via env var is clearly documented. Verify that if SSL env var is unset, the default 'true' remains in effect. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%
None
5. src/main/resources/application.conf:45
- Draft comment:
Confirm that overriding sslmode (default 'verify-full') via SSL_MODE is intended, and ensure it isn’t used inadvertently in production. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%
None
6. src/main/resources/application.conf:47
- Draft comment:
Validate that providing an override for sslfactory via SSL_FACTORY is necessary and well documented. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%
None
7. src/main/resources/application.conf:35
- Draft comment:
Typographical error: It appears that the key 'postNumber' on line 35 is a typo and should be 'portNumber' to be consistent with the intended configuration property. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_XD2D50IKE5r2L3DK
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Enable local override of PostgreSQL SSL settings in
application.confusing environment variables.application.conf, PostgreSQL SSL settings can now be overridden by environment variablesSSL,SSL_MODE, andSSL_FACTORY.This description was created by
for 300792f. It will automatically update as commits are pushed.